Improve handling of overlapping aliases in APP commands #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfclere
approved these changes
Oct 24, 2024
|
I don't see how to trigger the problem adding a war in a running tomcat... But the fix makes sense. |
Resolves MODCLUSTER-824
IIUC it's fairly reare, but not impossible situation, no? Reconfigure the server to add a new alias, kill the server, start it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an app would get merged into an existing vhost only in case the first alias would be already in. So that VHost with alias
testwould be updated for command withAlias=test,demobut a new VHost would be created forAlias=demo,test.This PR changes the behavior. Now we go through all provided aliases sequentially, and if one matches, the corresponding VHost gets updated. Otherwise a new one is created.
Resolves MODCLUSTER-824