Set logging level before calling test_tool_with_logging #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Member
|
👍 makes sense, that's consistent with the flow chart in the spec: thanks for this change! |
pcarleton
approved these changes
Nov 20, 2025
Member
|
just saw this in the schema for log message:
more evidence this was a good change, if we required you setting a log level, we'd be bumping that MAY to a MUST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR makes a small change to the test_tool_with_logging test, to set the logLevel before calling the tool.
Currently the test does not set the logLevel and expects the default logLevel lets through at least informational messages.
I think this assumption and not clearly required in the spec.
The current behavior of the C# SDK is that no log messages are sent unless the client sets the log level.
How Has This Been Tested?
Tested with a server built with the C# MCP SDK.
Breaking Changes
This should not affect any implementations currently passing the tests.
Types of changes
Checklist
Additional context