Add sep-835 limit retry scenario, add suite options to server command and update pending scenarios #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and negative test
…atting 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
commit: |
felixweinberger
requested changes
Nov 21, 2025
Collaborator
felixweinberger
left a comment
There was a problem hiding this comment.
I think there might be some changes unrelated to the PR description in this PR?
Comment on lines
+426
to
+432
| * Scenario 5: Client implements retry limits for scope escalation | ||
| * | ||
| * Tests that clients SHOULD implement retry limits to avoid infinite | ||
| * authorization loops when receiving repeated 403 insufficient_scope errors. | ||
| * The server always returns 403 with the same scope requirement, and clients | ||
| * should stop retrying after a reasonable number of attempts (3 or fewer). | ||
| */ |
Collaborator
There was a problem hiding this comment.
Is this here intentionally? Seems unrelated to adding the CLI option, looks like an entirely new scenario
Comment on lines
+16
to
+19
| /** | ||
| * Broken client that retries auth infinitely without any retry limit. | ||
| * BUG: Does not implement retry limits, causing infinite auth loops. | ||
| */ |
Collaborator
There was a problem hiding this comment.
Is this file intentionally included?
felixweinberger
approved these changes
Nov 21, 2025
Collaborator
felixweinberger
left a comment
There was a problem hiding this comment.
Actually never mind looks like the description does call out some additional changes unrelated to suite options
Member
Author
|
thanks, the description was not very good, just fixed it and the title |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds several improvements to the conformance test suite:
Retry limit test & negative test - Added test scenario for infinite retry behavior and a broken client implementation for negative testing
Suite options for server command - Added
--suiteflag with options:active(default): Runs only active scenarios, excluding pending onesall: Runs all scenarios including pendingpending: Runs only pending scenarios to check if they've been fixedUpdated pending scenarios list - Moved elicitation scenarios to pending while waiting for the schema fix in Make mode in elicitation backwards compatible modelcontextprotocol#1863
Auth scope test improvements - Fixed WWW-Authenticate header handling in scope scenarios
Lefthook configuration - Made dependency installs optional in local lefthook hooks
Usage
Test plan
🤖 Generated with Claude Code