SSE client transport: tolerate return of RPC responses in POST requests. #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
commented
May 22, 2025
eiriktsarpalis
commented
May 22, 2025
halter73
reviewed
May 22, 2025
halter73
approved these changes
May 23, 2025
77f9e64
into
modelcontextprotocol:main
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstates a piece of logic that tolerated the return of responses in the POST request itself. I've tweaked the heuristic somewhat so that it only falls back to that mode if the response content type is
application/json. I have tested this against the impacted MCP server (Haystack Search) and validated that the fix works. cc @AArnottFix #439.