Fix stdio client transport CLI argument escaping. #811
+131
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jozkee |
jozkee
reviewed
Sep 22, 2025
jozkee
approved these changes
Sep 22, 2025
stephentoub
approved these changes
Sep 22, 2025
eiriktsarpalis
commented
Sep 24, 2025
| string id = Guid.NewGuid().ToString("N"); | ||
|
|
||
| StdioClientTransport transport = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? | ||
| new(new() { Command = "cmd", Arguments = ["/C", $"echo \"{id}\" >&2"] }, LoggerFactory) : |
There was a problem hiding this comment.
@PederHP @jeffhandley A side effect of this change is that inserting shell pipe syntax in the CLI arguments is no longer possible. I think this is ok given it's a Windows-specific quirk, but I thought I'd double check.
There was a problem hiding this comment.
Just some ideas, we could:
- Not change the behavior and defer to users the escaping of characters like &, we could also augment the remarks around
StdioClientTransportOptions.Arguments. - Use Arguments instead of ArgumentList, but that requires implementing our own escaping, basically a copy of PasteArguments that wraps the argument in quotes if it contains &.
9d3db19 to
7505d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #594.