Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

IAmSurajBobade
Copy link
Contributor

mcp/protocol: Implement SEP-973 specification

Fixes #552

@IAmSurajBobade
Copy link
Contributor Author

@findleyr, please note - this changes currently do not work with MCP Inspector 0.17.0, as modelcontextprotocol/modelcontextprotocol#1531 is not implemented yet. I have created issue modelcontextprotocol/inspector#861 to track this.

Copy link
Contributor

@findleyr findleyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!

Can you add a basic smoke test (perhaps just adding to TestEndToEnd) that verifies the client receives the new metadata correctly?

(I'm sure it works, but good to have at least one end-to-end test).

@findleyr
Copy link
Contributor

@findleyr, please note - this changes currently do not work with MCP Inspector 0.17.0, as modelcontextprotocol/modelcontextprotocol#1531 is not implemented yet. I have created issue modelcontextprotocol/inspector#861 to track this.

Ah, this is a really important point. We need to not return this data based on the client's protocol version!
This definitely warrants a test!

@IAmSurajBobade
Copy link
Contributor Author

Thanks for this change!

Can you add a basic smoke test (perhaps just adding to TestEndToEnd) that verifies the client receives the new metadata correctly?

(I'm sure it works, but good to have at least one end-to-end test).

Yes, was about to ask, if we are good with this changes. I will add tests accordingly.

@IAmSurajBobade
Copy link
Contributor Author

IAmSurajBobade commented Oct 11, 2025

I have updated E2E tests. And updated streamable tests - which were using shared object.

We need to not return this data based on the client's protocol version!

As of now, Inspector integration fails, as specification draft has changed after original changes were incorporated in inspector. I am not sure, if this would still be a braking change for clients implementing '2025-06-18' or earlier protocol.

@findleyr if we have to omit this info from server, could you please suggest, how we should go about it? Considering we may have to implement similar checks for future specs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement SEP-973: Icons and metadata support

2 participants