feat: Add Pagination for server requests #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c05e1a to
8d48b93
Compare
chemicL
requested changes
Apr 23, 2025
mcp/src/main/java/io/modelcontextprotocol/spec/McpParamsValidationError.java
Outdated
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/spec/McpParamsValidationError.java
Outdated
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/server/McpAsyncServer.java
Outdated
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/server/McpAsyncServer.java
Outdated
Show resolved
Hide resolved
|
Hi, thanks for your review and your feedback!
Yes I will do this. I should be able to update the pull request by the end of the week. |
3dce44d to
0c93c71
Compare
0c93c71 to
b02db82
Compare
|
I did another push with small changes in the commit title and message and have also changed a few comments and names in tests. No business logic was affected. |
3718965 to
5f7bb9b
Compare
Adds the Pagination feature as described in the specification for prompts, resources, resource templates and tools. To make this possible mainly two changes are made: 1. The logic for cursor handling is added. 2. Handling for invalid parameters (MCP error code `-32602 (Invalid params)`) is added to the `McpServerSession`. For now the cursor is the base64 encoded start index of the next page and the hash value of the collection at time of computing. The page size is set to 10. When parameters are found to be invalid the newly introduced `McpParamsValidationError` is returned to handle it properly in the `McpServerSession`.
5f7bb9b to
094088d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Pagination feature to the
prompts/listfeature to fulfil the specification.Motivation and Context
This adds the Pagination feature to the
prompts/listfeature as described in the specification.To make this possible mainly two changes are made:
-32602 (Invalid params)) is added to theMcpServerSession.Decisions made:
base64string.10.McpParamsValidationErroris returned to handle it properly in theMcpServerSession.If this change is ok, I'm happy to create a follow-up PR for the other MCP features. Maybe some parts of the cursor handling can be moved out to separate methods.
How Has This Been Tested?
Integration tests are added for the
prompts/listfeature.Types of changes
Checklist