Allow samples to run against local builds using mavenLocal() #197
+35
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extprotocol#196) This ensures that the PR action and local development are guaranteed to be using the latest version.
eeafc29 to
7ebe530
Compare
kpavlov
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
Thank you @MarkusBillharz
That makes sense. Let's resolve conflicts and merge
|
I have reproduced this PR here #275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces minimal changes to allow contributors to run the sample projects against local builds of the SDK, without breaking the independence of the samples.
Resolves #196
Changes
This avoids directly linking the samples to the main project (as discussed in #119 (review)), while making it easier to test local changes during development.
To test it, I fake version bumped it on my clone to check that it is actually working as intended:
https://github.com/MarkusBillharz/kotlin-sdk/actions/runs/16523835710/job/46731929589
Types of changes
Feedback welcome!