-
Notifications
You must be signed in to change notification settings - Fork 1.2k
add ResourceLink to CallToolResult #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ace8816
add ResourceReference to CallToolResult
bhosmer-ant 307ab83
Include a discriminated LinkedResource for embedding Resources in Too…
evalstate 4641c3e
preparing documentation updates
evalstate 22e8b33
changed ordering, rerun schema gen
evalstate 1d3f8a4
Include a discriminated LinkedResource for embedding Resources in Too…
evalstate f156eb7
preparing documentation updates
evalstate e8568dd
update to is-a rather than contains-a relationship for linked resource.
evalstate 5867635
add docs
bhosmer-ant b88a807
generate schema.json
bhosmer-ant 2559ad4
update schema.ts comment
bhosmer-ant 70868f9
rebase, format
bhosmer-ant 4e6e4c6
fix changelog link
bhosmer-ant bfbd362
LinkedResource -> ResourceLink
bhosmer-ant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a good time to merge turns this in to an Array similar to the existing ToolCallResult.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look at that discussion, seems well motivated to me but I think best to keep it a separate PR