Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented Jul 8, 2025

Removes the redundant MAXIMUM_MESSAGE_SIZE check from the HTTP transport layer. The validation was performed after loading the entire request body into memory, providing no actual memory protection.

Changes

  • Removed post-body-read size validation from _handle_post_request()

Rationale

  • Check executed after await request.body(), making it ineffective for memory exhaustion prevention
  • ASGI servers handle flow control via backpressure mechanisms
  • Simplifies codebase by removing ineffective validation

@ihrpr ihrpr requested a review from Kludex July 8, 2025 12:09
@Kludex
Copy link
Member

Kludex commented Jul 8, 2025

Thanks!

@ihrpr ihrpr merged commit beacd6e into main Jul 8, 2025
11 of 13 checks passed
@ihrpr ihrpr deleted the ihrpr/remove-max-message-size branch July 8, 2025 14:56
saqadri pushed a commit to saqadri/stdio-fixes that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants