add regression tests for #1113 #1122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saqadri
pushed a commit
to saqadri/stdio-fixes
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1113 fixes a bug in FastMCP's simple logic for parsing structured data out of strings, by not attempting to parse JSON out of strings for arguments typed as
strin the tool's input schema. This PR adds regression tests.How Has This Been Tested?
Ran the new tests pre- and post-1113, confirmed they fail before and succeed after.
Breaking Changes
None in this PR - for #1113, code that was somehow relying on the explicit bug (tool signature types an argument as string, tool function receives deserialized JSON) would break, but a) seems like a vanishingly small class of edge cases and b) easily fixed by typing the argument properly.
Types of changes
Checklist