fix markdown error in README in main #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
approved these changes
Jul 15, 2025
Kludex
approved these changes
Jul 15, 2025
Comment on lines
+958
to
959
| # from starlette.routing import Route | ||
| # app.router.routes.append(Route("/", endpoint=other_route_function)) |
There was a problem hiding this comment.
This is actually bad advice. No one should use app.router.routes...
I think the idea is to mount the ASGI app from FastMCP into an existent Starlette application.
There was a problem hiding this comment.
Noted, I'll be re-writing more README today/tomorrow
saqadri
pushed a commit
to saqadri/stdio-fixes
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was added recently, when merging old PRs we might be introducing the failure in the main. Worth merging main before merge for old PRs touching README