Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sreenaths
Copy link
Contributor

Removing the unused instance variable notification_options from the server. A new variable is instantiated and initialized in init but never used. Instead fresh notification_options object is accepted as an argument in the create_initialization_options and get_capabilities functions.

Motivation and Context

This removes confusion about the use of notification_options in the server.

How Has This Been Tested?

Existing tests work as expected

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

None

Removing unused instance variable notification_options from the server
@sreenaths sreenaths requested a review from a team as a code owner August 4, 2025 22:36
@sreenaths sreenaths requested a review from domdomegg August 4, 2025 22:36
@sreenaths sreenaths marked this pull request as draft August 5, 2025 05:04
@sreenaths sreenaths closed this Aug 5, 2025
@domdomegg
Copy link
Member

Superceded by #1238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants