Doc update + validation in SseServerTransport + existing test fixes: addresses Issue: #827 #900
+44
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hoice was made. Realted Issue: modelcontextprotocol#827
Removed usage of snapshot in parametrised test as they don't work well together and end up failing the test.
Kludex
reviewed
Jun 7, 2025
tests/client/test_auth.py
Outdated
| @@ -968,8 +967,7 @@ def test_build_metadata( | |||
| revocation_options=RevocationOptions(enabled=True), | |||
| ) | |||
|
|
|||
| assert metadata == snapshot( | |||
| OAuthMetadata( | |||
| assert metadata == OAuthMetadata( | |||
There was a problem hiding this comment.
What is the error you were having?
There was a problem hiding this comment.
when I run uv run pytest I get the following error:
As a fix I tried running:
uv run pytest --inline-snapshot=fix tests/client/test_auth.py but got the same error again, alternatively I tried using Is for parameterised variables, but that did not seem like fully correct either.
There was a problem hiding this comment.
Few observations
- This test is passing in GitHub workflow
- In local, when I delete pycache and run
uv run pytest tests/client/test_auth.pyit passes - In local, when I run
uv run pytestit fails again
Since there does not seem to be an issue in the workflow I have reverted this change, or alternatively we can create explicit snapshot for each parameter similar to mentioned here.
ihrpr
requested changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SseServerTransportonly supports partial url forendpoint+ validating the same.test_messages_are_executed_concurrently: Removed flakiness from the test.test_build_metadata: Removed usage of snapshot in assert condition in the test. Using snapshot is failing the test even if the function itself is working. This was because of parameterisation. After some research online found that not using snapshot after creation would be a better way to handle this scenario.Motivation and Context
This relates to the issue reported here: #827
The doc string is slightly misleading as it mentioned that we can pass the absolute URL as well, which is not true in code implementation or best practices.
Fixed tests that were breaking when I run
uv run pytest.How Has This Been Tested?
Existing test cases pass.
Breaking Changes
No.
Types of changes
Checklist