Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(model): add ServerConfig and ClientConfig aliases - #1266

Open
DaleSeo wants to merge 1 commit into
mainfrom
deprecate-misleading-serverinfo-and-clientinfo-a
Open

feat(model): add ServerConfig and ClientConfig aliases#1266
DaleSeo wants to merge 1 commit into
mainfrom
deprecate-misleading-serverinfo-and-clientinfo-a

Conversation

@DaleSeo

@DaleSeo DaleSeo commented Sep 12, 2026

Copy link
Copy Markdown
Member

Motivation and Context

Follow-up to #1156. This PR introduces ServerConfig and ClientConfig as the recommended names for the values returned by ServerHandler::get_info and ClientHandler::get_info, and updates the ServerInfo and ClientInfo deprecation notes to point to them.

How Has This Been Tested?

Added tests

Breaking Changes

None

Public API Check is a false neative in CI. It does not check return types at all. A type alias is transparent, so a downstream fn get_info(&self) -> ServerInfo still satisfies a trait declared as -> ServerConfig. A newtype would have broken it, but an alias cannot.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@github-actions github-actions Bot added T-documentation Documentation improvements T-test Testing related changes T-core Core library changes T-examples Example code changes T-handler Handler implementation changes T-macros Macro changes T-service Service layer changes T-transport Transport layer changes labels Sep 12, 2026
@DaleSeo
DaleSeo marked this pull request as ready for review September 12, 2026 17:24
@DaleSeo
DaleSeo requested a review from a team as a code owner September 12, 2026 17:24
@DaleSeo DaleSeo linked an issue Sep 12, 2026 that may be closed by this pull request
@DaleSeo DaleSeo self-assigned this Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-core Core library changes T-documentation Documentation improvements T-examples Example code changes T-handler Handler implementation changes T-macros Macro changes T-service Service layer changes T-test Testing related changes T-transport Transport layer changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate misleading ServerInfo and ClientInfo aliases

1 participant