feat(model): add ServerConfig and ClientConfig aliases - #1266
Open
DaleSeo wants to merge 1 commit into
Open
Conversation
DaleSeo
marked this pull request as ready for review
September 12, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow-up to #1156. This PR introduces
ServerConfigandClientConfigas the recommended names for the values returned byServerHandler::get_infoandClientHandler::get_info, and updates theServerInfoandClientInfodeprecation notes to point to them.How Has This Been Tested?
Added tests
Breaking Changes
None
Public API Check is a false neative in CI. It does not check return types at all. A type alias is transparent, so a downstream
fn get_info(&self) -> ServerInfostill satisfies a trait declared as-> ServerConfig. A newtype would have broken it, but an alias cannot.Types of changes
Checklist