-
Notifications
You must be signed in to change notification settings - Fork 976
test(server): add more tests for SSEServerTransport
class
#391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(server): add more tests for SSEServerTransport
class
#391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for improving SDK. Sorry about the delay in PR reviews. Those files have conflicts now, please can you merge main and please revert package-lock changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, looks like test "should return 202 if message has a valid schema" is failing in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Motivation and Context
I've been skimming through the code and discovered that there is an opportunity to add more tests to the
SSEServerTransport
class. That's it!Note: the
package-lock.json
change is not intended but it seems to be missing the recent update. Happy to revert though.How Has This Been Tested?
I added unit tests.
Breaking Changes
Types of changes
Checklist
Additional context