Thanks to visit codestin.com
Credit goes to github.com

Skip to content

rename decline to reject #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

rename decline to reject #657

merged 2 commits into from
Jun 18, 2025

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented Jun 18, 2025

As discussed in discord, better to have reject than decline

@ihrpr ihrpr requested a review from bhosmer-ant June 18, 2025 19:12
Copy link
Contributor

@bhosmer-ant bhosmer-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one search/replace thing inline

return {
content: [
{
type: 'text',
text: `No information was collected. User declined to provide ${infoType} information.`,
text: `No information was collected. User rejectd to provide ${infoType} information.`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

maybe "User rejected ${infoType} information request."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find/replace technique is not perfect 😬

Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it's reasonable to blame Claude in all such situations

@ihrpr ihrpr merged commit 00a631c into main Jun 18, 2025
5 checks passed
@ihrpr ihrpr deleted the ihrpr/decline-reject branch June 18, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants