Add MODELSCOPE_CREDENTIALS_PATH for user-defined authorization path #1423
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @wangxingjun778, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request provides enhanced flexibility for users by enabling them to define a custom location for ModelScope credentials. By introducing an environment variable, it allows for greater control over where sensitive information is stored, which can be beneficial for security, system organization, or specific deployment scenarios, while maintaining a sensible default.
Highlights
- User-defined Credentials Path: I've introduced the
MODELSCOPE_CREDENTIALS_PATHenvironment variable, allowing users to specify a custom directory for storing ModelScope credentials (e.g., tokens, cookies). - Default Fallback Mechanism: The system will now check for the
MODELSCOPE_CREDENTIALS_PATHenvironment variable. If it's not set, it will gracefully fall back to the existing default credentials path, ensuring backward compatibility. - Configuration Update: The
ModelScopeConfigclass has been updated to utilize this new environment variable-driven path for credential management, centralizing the logic for determining the credentials storage location.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new environment variable MODELSCOPE_CREDENTIALS_PATH to allow users to specify a custom path for their credentials. An empty environment variable could cause a crash, and I've suggested a more robust way to handle this case.
| MODELSCOPE_CREDENTIALS_PATH = os.environ.get( | ||
| 'MODELSCOPE_CREDENTIALS_PATH', DEFAULT_CREDENTIALS_PATH.as_posix()) |
There was a problem hiding this comment.
If the MODELSCOPE_CREDENTIALS_PATH environment variable is set but empty, the application might crash due to an invalid path. To prevent this, ensure that an empty environment variable falls back to the default credentials path.
| MODELSCOPE_CREDENTIALS_PATH = os.environ.get( | |
| 'MODELSCOPE_CREDENTIALS_PATH', DEFAULT_CREDENTIALS_PATH.as_posix()) | |
| MODELSCOPE_CREDENTIALS_PATH = os.environ.get( | |
| 'MODELSCOPE_CREDENTIALS_PATH', None) or DEFAULT_CREDENTIALS_PATH.as_posix() |
No description provided.