Fix use_cookies in get_model_files #1424
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @wangxingjun778, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an inconsistency in how the use_cookies parameter was handled when calling the get_model_files method from other API functions like file_exists and delete_files. The changes ensure that cookie usage is properly propagated, improving the reliability and correctness of interactions with the model hub, especially concerning authentication and access to private models.
Highlights
- Cookie Handling in
file_exists: Thefile_existsmethod now explicitly retrieves cookies usingModelScopeConfig.get_cookies()and passes theuse_cookiesparameter toself.get_model_files. This ensures that cookie usage is correctly managed when checking for file existence, preventing potential authentication issues. - Cookie Handling in
delete_files: Thedelete_filesmethod has been updated to consistently pass theuse_cookiesparameter toself.get_model_files. This aligns the cookie handling logic across different API operations that interact with model files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where cookies were not being passed to get_model_files, which prevented operations on private repositories. The changes in file_exists and delete_files are logical and address the problem effectively. I've added one minor suggestion to improve code readability.
| repo_id, | ||
| recursive=True, | ||
| revision=revision, | ||
| use_cookies=False if cookies is None else cookies, |
There was a problem hiding this comment.
For improved readability, it's often better to state the positive case first in a conditional expression. Rephrasing this to check for cookies is not None makes the logic slightly clearer at a glance.
| use_cookies=False if cookies is None else cookies, | |
| use_cookies=cookies if cookies is not None else False, |
No description provided.