Feat/support repo info #1483

alcholiclg · 2025-08-28T13:25:43Z

This PR adds features to HubApi:

Add repo_info support for retrieving repository-level metadata (datasets, models) and latest commit info.
Add list_repo_commits for fetching full repository commit history.
Support compatibility with undefined parameters in ModelInfo and DatasetInfo.

Usage example:

from modelscope.hub.api import HubApi

api = HubApi()
# repo_id = 'Qwen/Qwen3-Coder-480B-A35B-Instruct'
# repo_type = 'model'
repo_id = 'swift/Chinese-Qwen3-235B-2507-Distill-data-110k-SFT'
repo_type = 'dataset'

repo_info = api.repo_info(repo_id=repo_id, repo_type=repo_type)

…ats to datetime

…ommits

Merge remote-tracking branch 'upstream' into feat/support_repo_info

gemini-code-assist

Summary of Changes

Hello @alcholiclg, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the HubApi by introducing new functionalities to retrieve comprehensive repository information. It adds a unified repo_info method to fetch detailed metadata for both models and datasets, including their latest commit details. Furthermore, it provides a list_repo_commits method to access the full commit history of a repository. The changes also improve the robustness of ModelInfo and DatasetInfo classes by making them compatible with potentially undefined parameters and integrating the new commit information.

Highlights

New repo_info API: A unified method HubApi.repo_info is introduced to fetch detailed metadata for both models and datasets, including their latest commit information.
Commit History Retrieval: A new HubApi.list_repo_commits method allows fetching the complete commit history for any given model or dataset repository.
Enhanced Model and Dataset Information: The ModelInfo and DatasetInfo classes are updated to include fields for the latest commit SHA (sha), the full latest commit object (last_commit), and the last_modified timestamp, providing richer repository metadata.
Improved Data Class Robustness: ModelInfo and DatasetInfo constructors are made more resilient to handle missing or undefined parameters, ensuring backward compatibility.
Timestamp Conversion Utility: A new convert_timestamp utility function is added to modelscope.hub.utils.utils to reliably convert various timestamp formats (UNIX, ISO strings) into timezone-aware datetime objects.
New Data Structures: OrganizationInfo, DetailedCommitInfo, and CommitHistoryResponse dataclasses are introduced to better structure and manage the retrieved repository and commit data.
Comprehensive Test Coverage: A new test file tests/hub/test_hub_repo_info.py is added, providing extensive unit tests for the new API methods and the enhanced data classes, including tests with real repository data.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces significant enhancements to the HubApi by adding support for retrieving repository information (repo_info) and commit history (list_repo_commits). The implementation includes new data classes for models, datasets, and organizations, which is a good approach. However, I've identified a few critical issues, such as type mismatches in dataclass initializers that could cause runtime errors, and some flawed error handling logic. Additionally, there are opportunities to improve code quality and robustness. The inclusion of comprehensive tests is a great practice.

modelscope/hub/api.py

gemini-code-assist · 2025-08-28T13:28:14Z

modelscope/hub/api.py

+        self.author = kwargs.pop('author', '')
+
+        # backward compatibility
+        self.__dict__.update(kwargs)


Using self.__dict__.update(kwargs) for backward compatibility can be risky. It makes the object's attributes dynamic and dependent on the API response, which can hide issues like typos in keys from the API. For improved robustness, it's better to explicitly handle all expected keys and perhaps log a warning for any unexpected keys remaining in kwargs.

gemini-code-assist · 2025-08-28T13:28:14Z

modelscope/hub/api.py

+            self.last_modified = None
+
+        # backward compatibility
+        self.__dict__.update(kwargs)


Using self.__dict__.update(kwargs) for backward compatibility can be risky. It makes the object's attributes dynamic and dependent on the API response, which can hide issues like typos in keys from the API. For improved robustness, it's better to explicitly handle all expected keys and perhaps log a warning for any unexpected keys remaining in kwargs.

gemini-code-assist · 2025-08-28T13:28:14Z

modelscope/hub/api.py

+        if is_relative_path(repo_id) and repo_id.count('/') == 1:
+            _owner, _dataset_name = repo_id.split('/')
+        else:
+            raise ValueError(f'Invalid repo_id: {repo_id} !')


The variables _owner and _dataset_name are assigned but never used. They should be removed to improve code clarity. The validation logic can be simplified.

Suggested change

if is_relative_path(repo_id) and repo_id.count('/') == 1:

_owner, _dataset_name = repo_id.split('/')

else:

raise ValueError(f'Invalid repo_id: {repo_id} !')

if not (is_relative_path(repo_id) and repo_id.count('/') == 1):

raise ValueError(f'Invalid repo_id: {repo_id} !')

gemini-code-assist · 2025-08-28T13:28:15Z

modelscope/hub/api.py

+        except requests.exceptions.RequestException as e:
+            raise Exception(f'Failed to get repository commits for {repo_id}: {str(e)}')


Raising a generic Exception can obscure the original error and make debugging more difficult. It's better to raise a more specific exception, like RequestError, and chain the original RequestException using from e to preserve the stack trace.

Suggested change

except requests.exceptions.RequestException as e:

raise Exception(f'Failed to get repository commits for {repo_id}: {str(e)}')

except requests.exceptions.RequestException as e:

raise RequestError(f'Failed to get repository commits for {repo_id}: {str(e)}') from e

Merge remote-tracking branch 'upstream' into feat/support_repo_info

modelscope/hub/api.py

…cope into feat/support_repo_info Merge branch 'feat/support_repo_info' of github.com:alcholiclg/modelscope into feat/support_repo_info

alcholiclg added 4 commits August 28, 2025 20:36

add convert_timestamp utility to support converting various time form…

66d0b6b

…ats to datetime

enable repo_info to read repo-level data (model, dataset) and fetch c…

04db1f6

…ommits

add unittest for repo_info

b79425b

Merge remote-tracking branch 'upstream' into feat/support_repo_info

468a396

Merge remote-tracking branch 'upstream' into feat/support_repo_info

gemini-code-assist bot reviewed Aug 28, 2025

View reviewed changes

alcholiclg and others added 4 commits August 28, 2025 21:37

correct handling of certain default values

83b2b69

refine error handling logic

031a74c

fix lint

0d7aab5

Merge remote-tracking branch 'upstream' into feat/support_repo_info

16e8e18

Merge remote-tracking branch 'upstream' into feat/support_repo_info

wangxingjun778 reviewed Aug 29, 2025

View reviewed changes

modelscope/hub/api.py Outdated Show resolved Hide resolved

modelscope/hub/api.py Outdated Show resolved Hide resolved

modelscope/hub/api.py Show resolved Hide resolved

modelscope/hub/api.py Outdated Show resolved Hide resolved

modelscope/hub/api.py Outdated Show resolved Hide resolved

alcholiclg and others added 4 commits August 29, 2025 14:50

Merge branch 'feat/support_repo_info' of github.com:alcholiclg/models…

92d4c1a

…cope into feat/support_repo_info Merge branch 'feat/support_repo_info' of github.com:alcholiclg/modelscope into feat/support_repo_info

correct typos and minor logic issues

4bf4850

correct function parameter passing error

0c90a57

update

26e412a

wangxingjun778 approved these changes Aug 29, 2025

View reviewed changes

wangxingjun778 merged commit 2fc6d8e into modelscope:master Aug 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat/support repo info #1483

Feat/support repo info #1483

Uh oh!

alcholiclg commented Aug 28, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Aug 28, 2025

Uh oh!

gemini-code-assist bot Aug 28, 2025

Uh oh!

gemini-code-assist bot Aug 28, 2025

Uh oh!

gemini-code-assist bot Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

		except requests.exceptions.RequestException as e:
		raise Exception(f'Failed to get repository commits for {repo_id}: {str(e)}')

Feat/support repo info #1483

Feat/support repo info #1483

Uh oh!

Conversation

alcholiclg commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alcholiclg commented Aug 28, 2025 •

edited

Loading