docs(examples): move geometry data to yml file, inline utilities#2264
Merged
Conversation
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Aug 8, 2024
modflowpy#2264 removed the module but neglected to remove this dependency from 3 examples
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Aug 8, 2024
modflowpy#2264 removed the notebook_utils.py module but neglected to remove this dependency from 3 examples
wpbonelli
added a commit
that referenced
this pull request
Aug 8, 2024
#2264 removed the notebook_utils.py module but neglected to remove this dependency from 3 examples: * export_vtk_tutorial.py * plot_cross_section_example.py * plot_map_view_example.py This is why these are missing from the develop version of the RTD site. This PR inlines the shared models which previously lived in notebook_utils.py. This duplication will go away once we have a models API as proposed in #1872.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small step towards #1872. Move geometry info to a YAML file under
examples/data/and move utils into scripts to removecommon/module import andsys.pathmanipulation. A later PR may introduce pooch as we have done for the mf6 examples: