fix(modelgrid): add more support for mf6 surface water models #2295
Merged
christianlangevin merged 2 commits intoAug 22, 2024
Conversation
7 tasks
martclanor
pushed a commit
to martclanor/flopy
that referenced
this pull request
Sep 21, 2024
…wpy#2295) * fix(modelgrid): add more support for mf6 surface water models * ruff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New MODFLOW 6 surface water models (overland flow and channel flow) use two dimensional and one dimensional grids. This PR adds an elegant fix to allow the grids to work properly with these new grid types (DISV1D, DIS2D, and DISV2D). These new grids do not have "top" but do have a "bottom" array (not "botm"). Plan for the future is to split up VertexGrid and StructuredGrid to support other types of grids.