fix(array3d_export): fix exporting of array3d to shp#2310
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2310 +/- ##
=========================================
+ Coverage 74.2% 75.6% +1.3%
=========================================
Files 294 294
Lines 59405 59555 +150
=========================================
+ Hits 44135 45066 +931
+ Misses 15270 14489 -781
|
36a72ad to
ae68e7a
Compare
Member
|
@martclanor the CI failures are unrelated and need not prevent this from merging if/when it's ready |
ae68e7a to
c93977b
Compare
Member
Author
|
Thank you for clearing that out! I think it's ready for review. |
wpbonelli
approved these changes
Sep 16, 2024
wpbonelli
left a comment
Member
There was a problem hiding this comment.
Thanks for wading in and fixing this @martclanor!
Member
|
The CI failures are due to actions/runner-images#10624. MF6 nightly build is broken for the same reason. I will wait to see if github fixes the mac runner image before trying to work around it. |
Member
|
The runner issue has been fixed upstream |
martclanor
added a commit
to martclanor/flopy
that referenced
this pull request
Sep 21, 2024
Fix the issue raised in discussion modflowpy#2308 - fix(MultiList): increment index per layer in build_list - fix(array3d_export): fix case for disu grid - add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to address the issue raised in discussion #2308