refactor(mf6): deprecate mf6 checks#2357
Merged
Merged
Conversation
christianlangevin
approved these changes
Nov 6, 2024
christianlangevin
left a comment
There was a problem hiding this comment.
just a minor comment about the warning message. looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate MF6 checks for the rest of the 3.x series. Consider either reworking/replacing them in 3.10+ in a backwards-compatible way, or removing them and making the
.check()methods on simulation model/package base classes no-ops, pending a 4.x rework.The sense after discussion is that the checks have limited utility at the moment, a few relevance/correctness issues, and see little use. Deprecating should help to determine if anyone is relying on them while we investigate how deeply they are woven into the existing framework.