fix(cvfdutil): fix skip_hanging_node_check#2423
Merged
Merged
Conversation
…ck, to avoid failure if the check is not necessary on some grids
wpbonelli
approved these changes
Jan 21, 2025
wpbonelli
left a comment
Member
There was a problem hiding this comment.
Thanks @oscarfasanchez I moved the vertexdict_keys assignment above the conditional since it's needed both within it and below.
Not sure why the check might hang indefinitely in your use case. Can you send us the script to reproduce it? Presumably that while loop is never exited.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2423 +/- ##
=========================================
+ Coverage 68.4% 76.3% +7.8%
=========================================
Files 294 294
Lines 59390 59855 +465
=========================================
+ Hits 40652 45690 +5038
+ Misses 18738 14165 -4573
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vertexdict_keys was put out of the if condition skip_hanging_node_check, to avoid failure if the check is not necessary on some grids
Related to issue #2321