refactor(resolve_exe): also fix tests#2464
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2464 +/- ##
=========================================
+ Coverage 68.4% 75.8% +7.4%
=========================================
Files 294 293 -1
Lines 59390 61906 +2516
=========================================
+ Hits 40652 46957 +6305
+ Misses 18738 14949 -3789
|
wpbonelli
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends a bit further than #2457 to resolve #2455 to use the str and PathLib versions of exe paths in the method. It also improves the docstring and return typing info.
But it also fixes
autotest/test_mbase.pywhich was broken on Linux for paths that have mixed case to the repo. Paths don't need to be converted tolower()for equality comparisons, as this breaks mixed-case paths. The tests are written to compare pathlib objects, which works for the host path, e.g. Windows paths:This also catches a missing warning thrown in
autotest/test_modflow.py.