Add the angldegx to the kw dictionary produced by the get_disu_kwarg method#2484
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2484 +/- ##
=========================================
- Coverage 76.0% 76.0% -0.1%
=========================================
Files 296 296
Lines 64051 64152 +101
=========================================
+ Hits 48742 48800 +58
- Misses 15309 15352 +43
🚀 New features to boost your workflow:
|
Contributor
Author
|
@wpbonelli Yes it is. |
Member
|
Looks reasonable based on my reading of the |
Contributor
Author
|
@wpbonelli @jlarsen-usgs Could one of you have a look at this and merge? |
Member
|
@jlarsen-usgs if you see anything wrong with this let us know, I merged to unblock @Manangka. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the new flux limiter the vertices and angledeg information are needed in the DISU grid
This commit adds that info to the kwargs produced by the get_disu_kwarg method.
I can imagine that this is also useful when using XT3D because it needs the same information