Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.6%. Comparing base (556c088) to head (8f75805).
Report is 6 commits behind head on develop.

@@            Coverage Diff             @@
##           develop   #2533      +/-   ##
==========================================
- Coverage     55.5%   36.6%   -18.9%     
==========================================
  Files          644     345     -299     
  Lines       124135   61808   -62327     
==========================================
- Hits         68947   22672   -46275     
+ Misses       55188   39136   -16052     

This flushed out some issues in our tests and in the synthetic valley mf6 example model. It seems a CRS string is required in some cases but we are not providing one. I'll defer here to someone more familiar with CRS and expectations of the rasters module maybe @jlarsen-usgs or @aleaf?

@emmanuel-ferdman did you find this reading through the code, or in the "real world"?

On second look, @mjreno and I are wondering if an error is really appropriate here. rasterio.from_user_input() will raise an error if it can't parse the CRS string. The fact that this has gone unnoticed for 6 years suggests we may not want to raise an error here?

I'm going to run with this and remove the error in the meantime to get our CI back up and running.

agreed that we should let rasterio raise this error.