Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9%. Comparing base (556c088) to head (88b88da).
Report is 13 commits behind head on develop.

@@            Coverage Diff             @@
##           develop    #2544     +/-   ##
==========================================
+ Coverage     55.5%    55.9%   +0.4%     
==========================================
  Files          644      640      -4     
  Lines       124135   123798    -337     
==========================================
+ Hits         68947    69265    +318     
+ Misses       55188    54533    -655     

@wpbonelli

Added another small fix to the request.

First time making this pull request here... I believe I should have made it in a different one. Just getting the hang of it (sorry :) )

@whcollab-proj no problem, thanks for the pr. can you run the ruff formatter/linter?

ideally these could be separate (with tests) but the changes are small. the first one is good, second one, I've never used GMG, are those input files supposed to support comments?

@wpbonelli

> @whcollab-proj no problem, thanks for the pr. can you run the ruff formatter/linter?

• Yes. Just did.

> ideally these could be separate (with tests) but the changes are small.

• Makes sense... I'll avoid lumping these kind of changes together... and add tests for more involved requests.

> the first one is good, second one, I've never used GMG, are those input files supposed to support comments?

• Apparently, those comment lines are also supported in the GMG solver input. Those can be added to input file via external tools. While loading data, flopy was already taking care of the comments prior the first dataset line (dataset 0), but the same check was not added for the following datasets (1, 2, and 3 https://water.usgs.gov/ogw/modflow/MODFLOW-2005-Guide/gmg.html).
  This change was mainly to replicate that check for other datasets, so an input similar to the following can be loaded without errors (ValueError)

  GMG input example:

#Geometric Multigrid Solver: Input Instruction
# [RCLOSE] [IITER] [HCLOSE] [MXITER]
0.01 10 0.01 25
# [DAMP] [IADAMP] [IOUTGMG] [IUNITMHC]
1 0 1 6
# [ISM] [ISC] [DUP] [DLOW] [CHGLIMIT]
0 0 0.75 0.25 10
# [RELAX]
1