Fix: Strip quotes from filenames in OPEN/CLOSE statements (when present) making ulstrd function a bit more forgiving with external input files#2545
Merged
wpbonelli merged 1 commit intoJul 15, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2545 +/- ##
==========================================
+ Coverage 55.5% 55.9% +0.4%
==========================================
Files 644 640 -4
Lines 124135 123800 -335
==========================================
+ Hits 68947 69266 +319
+ Misses 55188 54534 -654
🚀 New features to boost your workflow:
|
wpbonelli
reviewed
Jul 14, 2025
wpbonelli
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small safety fix to handle filenames in
OPEN/CLOSElines that are surrounded by quotes, which can sometimes be present in MODFLOW input files. For example:OPEN/CLOSE 'external_data.dat'
OPEN/CLOSE "external_data.dat"
If that is the case, in the attempt to load the data we might get an error similar to the following:
Package.load() error: open/close filename /.../'external_data.dat' not found