feat(utils): add normalization option for to_cvfd to add hanging nodes#2547
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2547 +/- ##
==========================================
+ Coverage 55.5% 55.9% +0.4%
==========================================
Files 644 641 -3
Lines 124135 123882 -253
==========================================
+ Hits 68947 69346 +399
+ Misses 55188 54536 -652
🚀 New features to boost your workflow:
|
| array of x, y vertices | ||
| normalize : bool | ||
| normalize the coordinates when looking for hanging nodes. Normalization may be | ||
| needed in cases where vertices are in real world coordinates and have large |
There was a problem hiding this comment.
presumably to avoid precision loss. does one ever want no normalization with large coord values? just wondering if a parameter is needed or if it could be turned on for values above a threshold
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
@wpbonelli I don't have a good idea of what threhold would be good do you? Although there is a cost for normalizing maybe it should always be done. What do you think?
There was a problem hiding this comment.
We made a similar fix in PRT not long ago and always normalize, but this has made me wonder whether we should set a threshold there too. Not sure about an exact threshold value but I assume we pref accuracy over speed. I can try and find some precedents to follow
christianlangevin
left a comment
There was a problem hiding this comment.
This is a nice addition and should improve the reliability of this calculation. Unless there is a straightforward way to determine a threshold, seems like normalizing should always be done. As we discussed, could allow someone to shut it off for better performance if normalization is not needed.
No description provided.