Thanks to visit codestin.com
Credit goes to github.com

Skip to content

allow bindir to be a Path for get_modflow(.run_main) function#2560

Merged
wpbonelli merged 2 commits into
modflowpy:developfrom
martinvonk:bindir
Jul 28, 2025
Merged

allow bindir to be a Path for get_modflow(.run_main) function#2560
wpbonelli merged 2 commits into
modflowpy:developfrom
martinvonk:bindir

Conversation

@martinvonk

Copy link
Copy Markdown
Contributor

fixes #2558

@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.9%. Comparing base (556c088) to head (7dc4cdf).
⚠️ Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/get_modflow.py 50.0% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #2560     +/-   ##
==========================================
+ Coverage     55.5%    55.9%   +0.4%     
==========================================
  Files          644      641      -3     
  Lines       124135   123886    -249     
==========================================
+ Hits         68947    69346    +399     
+ Misses       55188    54540    -648     
Files with missing lines Coverage Δ
flopy/utils/get_modflow.py 63.3% <50.0%> (-0.4%) ⬇️

... and 76 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @martinvonk

@wpbonelli wpbonelli merged commit 33e2ce0 into modflowpy:develop Jul 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: bindir argument for get_modflow(.run_main) fails if type is Path

2 participants