Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(resample_to_grid): use rescale=True for scipy.interpolate.griddata#2565

Merged
wpbonelli merged 3 commits into
modflowpy:developfrom
wpbonelli:fix-2473
Aug 5, 2025
Merged

fix(resample_to_grid): use rescale=True for scipy.interpolate.griddata#2565
wpbonelli merged 3 commits into
modflowpy:developfrom
wpbonelli:fix-2473

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Aug 4, 2025

Copy link
Copy Markdown
Member

close #2472

@wpbonelli wpbonelli requested a review from mwtoews August 4, 2025 04:38
@wpbonelli wpbonelli marked this pull request as ready for review August 4, 2025 04:39
@codecov

codecov Bot commented Aug 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.2%. Comparing base (556c088) to head (6a91e9a).
⚠️ Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2565      +/-   ##
===========================================
+ Coverage     55.5%    72.2%   +16.7%     
===========================================
  Files          644      642       -2     
  Lines       124135   122025    -2110     
===========================================
+ Hits         68947    88179   +19232     
+ Misses       55188    33846   -21342     
Files with missing lines Coverage Δ
flopy/utils/rasters.py 70.9% <100.0%> (-3.1%) ⬇️

... and 379 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwtoews

mwtoews commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

I see different results with method="cubic", since this method handles the internal masked option differently. Perhaps only apply the scale option (only on L533) when method in ("linear", "nearest")?

@wpbonelli

Copy link
Copy Markdown
Member Author

@mwtoews did you mean, keep the second rescale on 583 unchanged?

@mwtoews

mwtoews commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

@mwtoews did you mean, keep the second rescale on 583 unchanged?

Probably fine with rescale=True, but I'm not familiar with the extrapolate_edges option. And I should point out that I didn't see specific test coverage for it.

@wpbonelli wpbonelli requested a review from jlarsen-usgs August 5, 2025 12:15
@wpbonelli wpbonelli merged commit bc849c6 into modflowpy:develop Aug 5, 2025
20 checks passed
@wpbonelli wpbonelli deleted the fix-2473 branch August 5, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: resample_to_grid function doesn't return correct values when method='nearest'

3 participants