Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(hfb): open/close support for HFB package#2569

Merged
jdhughes-dev merged 4 commits into
modflowpy:developfrom
jdhughes-dev:hfb-external
Aug 5, 2025
Merged

feat(hfb): open/close support for HFB package#2569
jdhughes-dev merged 4 commits into
modflowpy:developfrom
jdhughes-dev:hfb-external

Conversation

@jdhughes-dev

Copy link
Copy Markdown
Contributor

No description provided.

@jdhughes-dev jdhughes-dev requested a review from wpbonelli August 5, 2025 16:18
@codecov

codecov Bot commented Aug 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.2%. Comparing base (556c088) to head (056818d).
⚠️ Report is 27 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2569      +/-   ##
===========================================
+ Coverage     55.5%    72.2%   +16.7%     
===========================================
  Files          644      643       -1     
  Lines       124135   122107    -2028     
===========================================
+ Hits         68947    88271   +19324     
+ Misses       55188    33836   -21352     
Files with missing lines Coverage Δ
flopy/modflow/mfhfb.py 89.1% <100.0%> (+4.7%) ⬆️

... and 381 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread flopy/modflow/mfhfb.py
@jdhughes-dev jdhughes-dev requested a review from wpbonelli August 5, 2025 19:15

@wpbonelli wpbonelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is external file support needed in any other packages?

@jdhughes-dev

Copy link
Copy Markdown
Contributor Author

is external file support needed in any other packages?

@wpbonelli open/close is already supported for standard stress packages (transient lists). HFB is an outlier and does not support transient lists.

@jdhughes-dev jdhughes-dev merged commit 8041ec0 into modflowpy:develop Aug 5, 2025
20 checks passed
@jdhughes-dev jdhughes-dev deleted the hfb-external branch August 5, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants