Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(whitespace): use CR EOLs, trailing whitespace#2585

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
mwtoews:norm-whitespace
Sep 3, 2025
Merged

refactor(whitespace): use CR EOLs, trailing whitespace#2585
wpbonelli merged 1 commit into
modflowpy:developfrom
mwtoews:norm-whitespace

Conversation

@mwtoews

@mwtoews mwtoews commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

This PR only modifies whitespace with no other refactors. Some of these are identified with a local pre-commit configuration.

  • Convert the line-endings of a few .py files from CRLF (\r\n on Windows) to CR (\n on Unix), which is the norm for git repos; usually these auto-convert to CRLF on repo cones on Windows
  • Use trailing-whitespace to clip lines with trailing whitespace (which is harmless, just inconsistent)
  • Use end-of-file-fixer to makes sure files end in a newline

@codecov

codecov Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.94144% with 187 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.5%. Comparing base (556c088) to head (032bcb3).
⚠️ Report is 37 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/plot/styles.py 27.2% 88 Missing ⚠️
flopy/mf6/utils/output_util.py 72.4% 54 Missing ⚠️
flopy/modflow/mfag.py 91.1% 32 Missing ⚠️
flopy/utils/geospatial_utils.py 93.7% 13 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2585      +/-   ##
===========================================
+ Coverage     55.5%    72.5%   +16.9%     
===========================================
  Files          644      667      +23     
  Lines       124135   128601    +4466     
===========================================
+ Hits         68947    93252   +24305     
+ Misses       55188    35349   -19839
Files with missing lines Coverage Δ
flopy/mf6/utils/codegen/__init__.py 0.0% <ø> (ø)
flopy/mf6/utils/codegen/filters.py 0.0% <ø> (ø)
flopy/mf6/utils/model_splitter.py 65.0% <ø> (-9.9%) ⬇️
flopy/utils/geospatial_utils.py 93.7% <93.7%> (+0.6%) ⬆️
flopy/modflow/mfag.py 91.1% <91.1%> (ø)
flopy/mf6/utils/output_util.py 72.4% <72.4%> (-2.1%) ⬇️
flopy/plot/styles.py 27.2% <27.2%> (ø)

... and 402 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wpbonelli
wpbonelli approved these changes Sep 3, 2025
View reviewed changes

@wpbonelli wpbonelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mwtoews

@wpbonelli wpbonelli merged commit 05c5745 into modflowpy:develop Sep 3, 2025
31 of 32 checks passed
@mwtoews mwtoews deleted the norm-whitespace branch September 3, 2025 11:27
mwtoews added a commit to mwtoews/flopy that referenced this pull request Sep 4, 2025
@mwtoews
Add modflowpy#2585 to .git-blame-ignore-revs
afc9a2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpbonelli wpbonelli wpbonelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mwtoews @wpbonelli