Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: use PathLike and curdir concisely and consistently#2589

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
mwtoews:refactor-pathlike-curdir
Sep 5, 2025
Merged

refactor: use PathLike and curdir concisely and consistently#2589
wpbonelli merged 1 commit into
modflowpy:developfrom
mwtoews:refactor-pathlike-curdir

Conversation

@mwtoews

@mwtoews mwtoews commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This refactor is mostly related to PathLike and curdir from the os module.

  • Import these items to use as (e.g.) PathLike rather than os.PathLike
  • Try to make docstrings related to these more consistent
  • Replace typing Optional[Union[...]] with Union[..., None]

@codecov

codecov Bot commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.78261% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.5%. Comparing base (556c088) to head (9a1e778).
⚠️ Report is 40 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/compare.py 25.0% 9 Missing ⚠️
flopy/utils/zonbud.py 62.5% 3 Missing ⚠️
flopy/modflow/mfsfr2.py 50.0% 2 Missing ⚠️
flopy/modflowlgr/mflgr.py 50.0% 2 Missing ⚠️
flopy/export/netcdf.py 66.6% 1 Missing ⚠️
flopy/export/utils.py 95.4% 1 Missing ⚠️
flopy/mbase.py 85.7% 1 Missing ⚠️
flopy/mf6/utils/mfsimlistfile.py 75.0% 1 Missing ⚠️
flopy/pakbase.py 66.6% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2589      +/-   ##
===========================================
+ Coverage     55.5%    72.5%   +16.9%     
===========================================
  Files          644      667      +23     
  Lines       124135   128669    +4534     
===========================================
+ Hits         68947    93307   +24360     
+ Misses       55188    35362   -19826
Files with missing lines Coverage Δ
flopy/discretization/grid.py 75.7% <100.0%> (-0.3%) ⬇️
flopy/discretization/structuredgrid.py 47.6% <100.0%> (+0.1%) ⬆️
flopy/discretization/unstructuredgrid.py 75.1% <100.0%> (-6.4%) ⬇️
flopy/discretization/vertexgrid.py 78.9% <ø> (-4.8%) ⬇️
flopy/export/shapefile_utils.py 80.9% <100.0%> (-3.1%) ⬇️
flopy/export/vtk.py 68.4% <100.0%> (-9.7%) ⬇️
flopy/mf6/mfbase.py 75.0% <100.0%> (-12.7%) ⬇️
flopy/mf6/mfmodel.py 57.0% <100.0%> (-23.9%) ⬇️
flopy/mf6/mfpackage.py 68.4% <100.0%> (-13.2%) ⬇️
flopy/mf6/mfsimbase.py 62.2% <100.0%> (-13.2%) ⬇️
... and 31 more

... and 388 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mwtoews
mwtoews commented Sep 5, 2025
View reviewed changes
Comment thread flopy/mbase.py
Comment thread flopy/modpath/mp6.py
wpbonelli
wpbonelli approved these changes Sep 5, 2025
View reviewed changes

@wpbonelli wpbonelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this @mwtoews

@wpbonelli wpbonelli merged commit d25a851 into modflowpy:develop Sep 5, 2025
20 checks passed
@mwtoews mwtoews deleted the refactor-pathlike-curdir branch September 5, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpbonelli wpbonelli wpbonelli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mwtoews @wpbonelli