fix(get_transmissivities): support mf6 models#2611
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2611 +/- ##
===========================================
+ Coverage 55.5% 72.5% +17.0%
===========================================
Files 644 667 +23
Lines 124135 128990 +4855
===========================================
+ Hits 68947 93618 +24671
+ Misses 55188 35372 -19816
🚀 New features to boost your workflow:
|
2d178d2 to
9714a74
Compare
jlarsen-usgs
approved these changes
Sep 29, 2025
wpbonelli
added a commit
that referenced
this pull request
Jan 24, 2026
Follow up on #2611 to support DISU. Closes #2170. Plus forward-looking refactoring in case we add more grid types before 4.x comes out. Rather than conditionals everywhere to access/modify grid properties differently based on the grid type, add an adapter exposing what's needed consistently. This is necessary because grid properties may have different shapes depending on the grid type. In 4.x this can be avoided by design I think. But for now this makes the essence of the transmissivities calculation clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2170, support mf6 models with dis and disv grids, no disu yet