Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(compare_cell_budget): move cbb comparison function from mf6 tests#2636

Merged
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:compare
Oct 14, 2025
Merged

feat(compare_cell_budget): move cbb comparison function from mf6 tests#2636
wpbonelli merged 1 commit into
modflowpy:developfrom
wpbonelli:compare

Conversation

@wpbonelli

@wpbonelli wpbonelli commented Oct 14, 2025

Copy link
Copy Markdown
Member

Rehome cell by cell budget comparison function from MF6 autotests. Rename the old compare_budget to compare_list_budget to clarify but leave an alias to compare_budget.

@codecov

codecov Bot commented Oct 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.5%. Comparing base (556c088) to head (bd742f3).
⚠️ Report is 77 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/compare.py 14.2% 60 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2636      +/-   ##
===========================================
+ Coverage     55.5%    72.5%   +17.0%     
===========================================
  Files          644      667      +23     
  Lines       124135   129123    +4988     
===========================================
+ Hits         68947    93708   +24761     
+ Misses       55188    35415   -19773     
Files with missing lines Coverage Δ
flopy/utils/compare.py 13.8% <14.2%> (-13.2%) ⬇️

... and 558 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review October 14, 2025 01:56
@wpbonelli wpbonelli merged commit a84ca56 into modflowpy:develop Oct 14, 2025
19 checks passed
@wpbonelli wpbonelli deleted the compare branch October 14, 2025 02:08
@wpbonelli wpbonelli added this to the 3.10 milestone Oct 14, 2025
wpbonelli added a commit to MODFLOW-ORG/modflow6 that referenced this pull request Oct 15, 2025
cf modflowpy/flopy#2636, also tidy some type hints, fix RTD docs issues, and remove an old likely unused script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant