fix(mfusg): fix duplicate unit numbers in NAM file for MFUSG external files#2659
Merged
wpbonelli merged 1 commit intoDec 2, 2025
Conversation
When loading a model, DATA entries from the NAM file were being added to external_units even when they already existed in output_units (e.g., IUNITAFR from WEL package). This caused duplicate entries in the written NAM file. Added check for output_units in _prepare_external_files() to prevent adding unit numbers that are already registered as output files.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2659 +/- ##
===========================================
+ Coverage 55.5% 72.6% +17.1%
===========================================
Files 644 667 +23
Lines 124135 129356 +5221
===========================================
+ Hits 68947 93986 +25039
+ Misses 55188 35370 -19818
🚀 New features to boost your workflow:
|
wpbonelli
approved these changes
Dec 2, 2025
wpbonelli
left a comment
Member
There was a problem hiding this comment.
would be ideal to have a minimal test for this but presumably it is confirmed to work on your end @reneangermeyer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a model, DATA entries from the NAM file were being added to external_units even when they already existed in output_units (e.g., IUNITAFR from WEL package). This caused duplicate entries in the written NAM file.
Added check for output_units in _prepare_external_files() to prevent adding unit numbers that are already registered as output files.