fix: use share scope in loadShare cache key to prevent cross-scope collisions#822
Merged
gioboa merged 3 commits intoJun 16, 2026
Merged
Conversation
…llisions When multiple share scopes exist on the same page (e.g., react-18 and react-19 for cross-major React isolation via bridge components), the loadShare flat cache key ignores the scope. Whichever scope populates the cache first wins — all subsequent lookups return the wrong version. Prefix cache keys with `shareItem.scope:` (defaults to "default:") so scoped singletons like react-18:react and react-19:react don't collide. Also emit a runtime helper (__mfGetSharedCacheKey) for the three inline cache-key sites in virtualRemoteEntry that can't call the build-time getSharedCacheKey(). Co-Authored-By: Claude Opus 4.6 <[email protected]>
commit: |
4 tasks
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #821