fix: prefer installed shared version over requiredVersion (#829)#830
Merged
gioboa merged 2 commits intoJun 16, 2026
Merged
Conversation
Closed
4 tasks
commit: |
Collaborator
|
Fixes shared version precedence so the installed package version is preferred over a version inferred from requiredVersion. Example: if [email protected] is installed and shared config has requiredVersion: '^19.1.1', the manifest now advertises provider version: '19.2.7' instead of incorrectly inferring version: '19.1.1'. requiredVersion remains the consumer constraint; version now reflects what the build actually provides. |
Contributor
Author
|
@gioboa Thanks! Glad it helped π |
4 tasks
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #829.
This changes shared version normalization so
inferVersionFromRequiredVersion(requiredVersion)is only used as a last-resort fallback.Provider
versionnow resolves in this order:versionpackage.jsonrequiredVersionProblem
Previously,
normalizeShareItem()treated the inferredrequiredVersionvalue as part of the explicit version path:With
[email protected]installed andrequiredVersion: '^19.1.1', the generated shared metadata advertisedreactas provider version19.1.1.requiredVersionis a consumer constraint, whileversionshould describe the actual package version this build can provide.Changes
versionfrom the inferredrequiredVersionfallback.searchPackageVersion(key)before using the inferred fallback.[email protected]withrequiredVersion: '^19.1.1'.Validation
Results:
src/utils/__tests__/normalizeModuleFederationOption.test.ts: 30 passedpnpm test: 34 files, 520 tests passedtypecheck: passedfmt.check: passedbuild: passed