Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix dev manifest hashed remote entry#834

Merged
gioboa merged 2 commits into
mainfrom
fix/833
Jun 17, 2026
Merged

fix: fix dev manifest hashed remote entry#834
gioboa merged 2 commits into
mainfrom
fix/833

Conversation

@gioboa

@gioboa gioboa commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Close #833

  • Fix dev mf-manifest.json remote entry when filename contains [hash].
  • Serve stable dev remoteEntry.js while preserving existing virtual entry handling.
  • Add dev shared asset fallback to remoteEntry.js.
  • Fix prod SSR fallback to derive from emitted hashed remote entry.
  • Add regression tests for dev and build manifest filenames.

@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@module-federation/vite@834

commit: 2690494

@gioboa gioboa left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akiryazov
Can I ask you to test this pre-release please?

@akiryazov

Copy link
Copy Markdown

Yes, of course!

@gioboa gioboa left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests With Different Frameworks

Image

@akiryazov

Copy link
Copy Markdown

I can confirm that file names are looking better now, remoteEntry's name is remoteEntry.js and I see it also present for the shared modules. The only issue now is with what the MF exposes, there are no linked files for the exposed paths. All the arrays are empty there

@gioboa

gioboa commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

The only issue now is with what the MF exposes, there are no linked files for the exposed paths. All the arrays are empty there

I pushed the fix, tryΒ this new release please.
npm i https://pkg.pr.new/@module-federation/vite@2690494

@akiryazov

Copy link
Copy Markdown

Sorry for the delay, I was investigating and testing until now and will share my observations:

  • Now I see remoteEntry.js included everywhere
  • Since you mentioned yesterday that publicPath '/' resolves to 'auto' internally, I removed it from the configuration. However, this seems to not work for me, not sure if it's specifically for my case or not. For example when I try to access the remote app from the host, it tries to look for https://$hostURL/remoteEntry.js instead of https://$remoteURL/remoteEntry.js . Adding "publicPath": "auto" explicitly fixes it. It is a big ecosystem and I don't have access to the host app to check its configuration. However, I think I might change that if needed further investigation.
  • I managed to connect to the remote only by explicitly adding filename: "remoteEntry.js". Otherwise, for me it looks like it fallbacks to some code when file name is not specified, which names the entry point "remoteEntry-hash.js". At least this is what I saw in @id folder in the source files.
  • After successfully connecting to the remote on dev, I am able to load the remote files, but getting "$RefreshSig$ is not defined" error. Also not sure if it's related to the package or the project.
  • Preview mode still works fine

@gioboa

gioboa commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

I see, thanks for you check. I'll merge this PR and let's continue the discussion on the other points.

@gioboa gioboa merged commit cdd33cb into main Jun 17, 2026
22 checks passed
@gioboa gioboa deleted the fix/833 branch June 17, 2026 12:37
@akiryazov

Copy link
Copy Markdown

Thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: mf-manifest.json contains incorrect file names or missing them completely in dev mode

2 participants