Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: normalize trailing slash shares#837

Merged
gioboa merged 1 commit into
mainfrom
fix/836
Jun 18, 2026
Merged

fix: normalize trailing slash shares#837
gioboa merged 1 commit into
mainfrom
fix/836

Conversation

@gioboa

@gioboa gioboa commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Close #836

Align Vite shared normalization with Module Federation docs by treating known trailing-slash shares like react/ and react-dom/ as their package roots while preserving common subpath sharing.
This prevents Vite/Rolldown from resolving invalid package imports such as react-dom/.

@pkg-pr-new

pkg-pr-new Bot commented Jun 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@module-federation/vite@837

commit: a3f8e63

@gioboa gioboa left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests With Different Frameworks

Screenshot 2026-06-18 at 09 59 50

@gioboa gioboa merged commit fa5f2c1 into main Jun 18, 2026
22 checks passed
@gioboa gioboa deleted the fix/836 branch June 18, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent behavior with module-federation.io docs

1 participant