Conversation
commit: |
94c014a to
725b946
Compare
Contributor
|
Hi! @gioboa One thing I’m wondering about from the CI results: Vite 5/6/7 integration passes, but Vite 8 fails because it cannot find the The Playwright trace also shows the browser trying to fetch Could this be caused by a behavior difference in how Vite 8/Rolldown handles |
gioboa
commented
Jul 7, 2026
gioboa
left a comment
Collaborator
Author
There was a problem hiding this comment.
Tests With Different Frameworks
4 tasks
gioboa
added a commit
that referenced
this pull request
Jul 11, 2026
* fix: seed subpath shares before their package root Since the runtime shared cache seeding (#883), serve-mode share proxies no longer bind an eager local fallback: on a cache miss they defer export assignment until after federation init. The seed loop iterated usedShared in insertion (alphabetical) order, so seeding a package root evaluated its module graph while the package's own subpath shares were still unseeded — a self-referencing bare import like `import { builder } from 'pkg/api'` inside `pkg` then read undefined named exports at module-evaluation time and crashed consumers (same failure family as #767 and #805, now in dev serve). Seed shares in dependency order instead, treating a package's subpath share keys as dependencies of the package root, with a runtime fallback for share keys discovered after codegen. Co-Authored-By: Claude Fable 5 <[email protected]> * test: add late share ordering regression test * chore: improve code --------- Co-authored-by: Claude Fable 5 <[email protected]> Co-authored-by: gioboa <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #881
Make singleton shared fallback lazy during build and reuse cached shared modules before importing local providers, preventing duplicate downloads.