Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(mentions): check mentionPatterns even when explicit mention is available #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
obviyus merged 2 commits into from
Jan 29, 2026
Merged

fix(mentions): check mentionPatterns even when explicit mention is available #3303

obviyus merged 2 commits into from
Jan 29, 2026
+27 −10

Conversation

@HirokiKobayashi-R
Copy link
Contributor

@HirokiKobayashi-R HirokiKobayashi-R commented Jan 28, 2026

Summary

  • Fix mentionPatterns being ignored when an explicit <@USERID> style mention exists in the message
  • Previously, L93 in src/auto-reply/reply/mentions.ts returned early without checking mentionRegexes

Test plan

  • Unit tests updated and passing
  • Integration tests for Discord, Slack, Telegram updated
  • pnpm lint && pnpm build passes

@moltbot-barnacle moltbot-barnacle bot added channel: discord Channel integration: discord channel: slack Channel integration: slack channel: telegram Channel integration: telegram labels Jan 28, 2026
@obviyus obviyus self-assigned this Jan 29, 2026
@obviyus obviyus force-pushed the fix/mention-patterns-with-explicit branch from d4a5207 to 4a4f217 Compare January 29, 2026 05:01
@obviyus obviyus merged commit 16a5549 into openclaw:main Jan 29, 2026
1 check passed
@obviyus
Copy link
Contributor

obviyus commented Jan 29, 2026

Landed via temp rebase onto main.

  • Gate: pnpm lint && pnpm build && pnpm test
  • Land commit: 4a4f217
  • Merge commit: 16a5549

Thanks @HirokiKobayashi-R!

chikosan added a commit to chikosan/moltbot that referenced this pull request Jan 29, 2026
@chikosan @warp-agent
Merge PR openclaw#3303: Check mentionPatterns even when explicit ment…
27de773 
…ion available

Bug fix for mention checking logic to properly handle mention patterns.

Thanks to @HirokiKobayashi-R for the fix!

Co-Authored-By: Warp <[email protected]>
lawrence565 pushed a commit to lawrence565/moltbot that referenced this pull request Jan 29, 2026
@obviyus @lawrence565
docs: update changelog for mention patterns (openclaw#3303) (thanks @…
5339e26 
…HirokiKobayashi-R)
HirokiKobayashi-R pushed a commit to HirokiKobayashi-R/moltbot that referenced this pull request Jan 29, 2026
@obviyus @HirokiKobayashi-R
docs: update changelog for mention patterns (openclaw#3303) (thanks @…
2aae069 
…HirokiKobayashi-R)
mfgering pushed a commit to mfgering/mfg_moltbot that referenced this pull request Jan 29, 2026
@obviyus @bobbybob
docs: update changelog for mention patterns (openclaw#3303) (thanks @…
db94beb 
…HirokiKobayashi-R)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@obviyus obviyus

Labels

channel: discord Channel integration: discord channel: slack Channel integration: slack channel: telegram Channel integration: telegram

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HirokiKobayashi-R @obviyus