PHPLIB-373 Use DatabaseTransactionsManager in ManagesTransactions trait
#3443
+341
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91ca67e to
b88fa23
Compare
paulinevos
commented
Sep 4, 2025
b88fa23 to
67a9263
Compare
paulinevos
commented
Sep 4, 2025
jmikola
reviewed
Sep 4, 2025
GromNaN
reviewed
Sep 4, 2025
67a9263 to
d8ee028
Compare
14eed44 to
27ac702
Compare
GromNaN
reviewed
Sep 12, 2025
`DatabaseTransactionsManager` was introduced in Laravel to keep track of things like pending transactions and fire transaction events, so that e.g. dispatches could hook into transaction state. Our trait was not using it yet, resulting in missing `afterCommit` behavior (see PHPLIB-373)
27ac702 to
f63f985
Compare
GromNaN
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatabaseTransactionsManagerwas introduced in Laravel to keep track of things like pending transactions and fire transaction events, so that e.g. dispatches could hook into transaction state.Our trait was not using it yet, resulting in missing
afterCommitbehavior (see PHPLIB-373 and #3328)Checklist