Conversation
b3c05d1 to
01445e8
Compare
dariakp
reviewed
Mar 2, 2026
| socket = net.createConnection(parseConnectOptions(options)); | ||
| } | ||
|
|
||
| // Explicit setKeepAlive/setNoDelay are required because tls.connect() silently |
Contributor
There was a problem hiding this comment.
Is there anything we can do to test that the actual tls.connect() does not ignore the constructor option? The unit tests we are adding to ensure that we test the setKeepAlive call are fine, but imagine a new engineer coming across this comment in a couple of years, following the nodejs issue link, seeing that it's fixed in all relevant node versions, and then removing this logic that's now redundant with the constructor options. And then imagine this bug getting reintroduced in a later node version - it would be nice if we had a regression test that would alert us if that happened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Revert previous behaviour of explicitly calling setKeepAlive and setNoDelay on the socket due to the Node.js bug: nodejs/node#62004
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript