Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add typescript compilation to build script #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

nbbeeken
Copy link
Collaborator

Description

What is changing?

  • Build typescript at the end of building the bindings
Is there new documentation needed for these changes?

No

What is the motivation for this change?

The build script runs npm install like so:

await run('npm', ['install', '--ignore-scripts']);

creates a prebuild, then finishes.

Because of '--ignore-scripts' it doesn't run the prepare lifecycle hook, so typescript isn't compiled.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James self-assigned this Jun 20, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 20, 2024
@W-A-James W-A-James merged commit 1ee8895 into main Jun 20, 2024
12 checks passed
@W-A-James W-A-James deleted the chore-add-ts-build branch June 20, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants