Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add a fastDownload flag to build script #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2024
Merged

chore: add a fastDownload flag to build script #26

merged 3 commits into from
Jun 20, 2024

Conversation

nbbeeken
Copy link
Collaborator

Description

What is changing?

  • Added a hack to speed up downloading for local dev peace of mind.
    • Using tar's output cut the untar process short if we haven't pulled any new memeber out of the tar for 3secs
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Download times go from 200s to 40s

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James self-assigned this Jun 20, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 20, 2024
@W-A-James W-A-James merged commit ea1f4a6 into main Jun 20, 2024
12 checks passed
@W-A-James W-A-James deleted the chore-add-fast-download-hack branch June 20, 2024 15:23
baileympearson pushed a commit that referenced this pull request Jun 20, 2024
@nbbeeken @baileympearson
chore: add a fastDownload flag to build script (#26)
ff8778c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

Assignees

@W-A-James W-A-James

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @W-A-James