check_procs: support of light weight processes (threads) #1601
+408
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd01163 to
46089d3
Compare
waja
added a commit
that referenced
this pull request
Apr 7, 2021
Using snprintf which honors the buffers size and guarantees null temination. (Closes: #1601)
waja
pushed a commit
that referenced
this pull request
Apr 7, 2021
…ination. (Closes: #1601) As strcpy may overflow the resulting buffer: flo@p5:~$ /tmp/f/usr/lib/nagios/plugins/check_pgsql -d "$(seq 1 10000)" *** buffer overflow detected ***: terminated Aborted I would propose to change the code rather like this, using snprintf which honors the buffers size and guarantees null termination.
waja
pushed a commit
to waja/monitoring-plugins
that referenced
this pull request
Apr 10, 2021
…ination. (Closes: monitoring-plugins#1601) As strcpy may overflow the resulting buffer: flo@p5:~$ /tmp/f/usr/lib/nagios/plugins/check_pgsql -d "$(seq 1 10000)" *** buffer overflow detected ***: terminated Aborted I would propose to change the code rather like this, using snprintf which honors the buffers size and guarantees null termination.
Author
|
@waja why is it closed? I would like to get any feedback. |
Member
46089d3 to
60d8131
Compare
Author
|
@waja i updated my PR to the current version to resolve all conflicts |
Member
|
@bkuebler Thanks for caring about the issue. You might have seen that the CI tests failed. I didn't looked into the PR itself, but if you didn't yet rebase your PR on recent master, I would recommend to do so. |
Author
|
Yes i am working on it and will fix it |
60d8131 to
07a6e03
Compare
07a6e03 to
38df3d0
Compare
Author
|
JFTR I try to complete all open issues within the next 3 weeks.
|
Member
Take your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use check_procs and it's mechanism to check threads on systems instead of processes. With this feature you can use "-n" flag to switch to threads overall instead of processes.
If you would like to use threads (lwp) in ps so calls NLWP (number of light weight processes) as metric now you can use "-m NLWP". For example if you use this you can check if the given process or any of the checked processes are reach the thread threshold defined with -c or -w